Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-OCT-1839: Set created_at field #376

Merged
merged 1 commit into from
Aug 9, 2024
Merged

FIX-OCT-1839: Set created_at field #376

merged 1 commit into from
Aug 9, 2024

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski self-assigned this Aug 2, 2024
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 2, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 2, 2024
housekeeper-bot
housekeeper-bot approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10214339892 passed 🎉

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 6, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 6, 2024
housekeeper-bot
housekeeper-bot approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10269590557 passed 🎉

paulperegud
paulperegud approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@paulperegud paulperegud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks safe to me.

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 9, 2024
@kgarbacinski kgarbacinski merged commit 6ba54d3 into develop Aug 9, 2024
71 of 73 checks passed
@kgarbacinski kgarbacinski deleted the kacper/fix/oct-1839-fulfill-created-at-field branch August 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@paulperegud paulperegud paulperegud approved these changes

@adam-gf adam-gf Awaiting requested review from adam-gf

Assignees

@kgarbacinski kgarbacinski

Labels
request-approval Request approval from the Housekeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgarbacinski @paulperegud @housekeeper-bot