Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2296: Improve BE stability #611

Merged
merged 5 commits into from
Jan 7, 2025
Merged

OCT-2296: Improve BE stability #611

merged 5 commits into from
Jan 7, 2025
+61 −115

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski self-assigned this Jan 2, 2025
@linear Linear
Copy link

linear bot commented Jan 2, 2025

OCT-2296 Improve the backend stability for Pooling and Database connection

@housekeeper-bot housekeeper-bot temporarily deployed to uat January 2, 2025 11:35 Destroyed
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 2, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 2, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12582992870 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 2, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 2, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12587677817 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 2, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 3, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12590433565 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 3, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 3, 2025
housekeeper-bot
housekeeper-bot approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12594959057 passed 🎉

@kgarbacinski kgarbacinski mentioned this pull request Jan 3, 2025
Merged
14 tasks
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 7, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 7, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12649831961 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jan 7, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 7, 2025
housekeeper-bot
housekeeper-bot approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12653589325 passed 🎉

@kgarbacinski kgarbacinski merged commit dfc37f7 into develop Jan 7, 2025
79 of 80 checks passed
@kgarbacinski kgarbacinski deleted the kacper/chore/oct-2296-improve-backend-stability branch January 7, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-gf adam-gf adam-gf approved these changes

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

Assignees

@kgarbacinski kgarbacinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgarbacinski @housekeeper-bot @adam-gf