Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project manager window size when EDSCALE is not 1.0. #101576

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 15, 2025

Fixes regression from #91889

Initial size set in the main/main.cpp do not account for EDSCALE (and it's currently impossible to fix, since calculation EDSCALE require functional DisplayServer and initial window size/position are passed to the DisplayServer constructor).

@bruvzg bruvzg added this to the 4.4 milestone Jan 15, 2025
@bruvzg bruvzg requested a review from a team as a code owner January 15, 2025 10:29
main/main.cpp Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

@bruvzg Just FYI, topic:gui is meant to be used mainly for changes to Control-derived nodes (scene/gui/, maybe editor/gui/, and text servers, etc.). For general editor UI, topic:editor is enough.

@akien-mga akien-mga changed the title Fix project manager window size when EDSCALE is not 1.0. Fix project manager window size when EDSCALE is not 1.0. Jan 15, 2025
@akien-mga akien-mga merged commit 5718845 into godotengine:master Jan 16, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke
Copy link
Member

Confirmed, this fixes the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants