Don't instantiate ColorPicker
in EditorPropertyColor
constructor
#101570
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EditorPropertyColor
constructor was usingColorPickerButton::get_popup()
andColorPickerButton::get_picker()
, which was instantiating the ColorPicker without it being opened first. This led to 40+ pickers being instantiated in some cases.This PR avoids calling those getters by utilizing the
ColorPickerButton::toggled
signal instead.On a debug build I get these results (quickly measured by eye & timer):
Editor Settings > Text Editor > Theme
:Switching away to another setting or inspector is faster now too, since there's no need to delete all the pickers.
However, now that it's using a different signal there may be a regression somewhere. The pickers work using both mouse or keyboard though.