Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnoweb): titles missing id and toc anchors #3538

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexiscolin
Copy link
Member

Fixes issues related to the table of contents in gnoweb (realms). The links were not working because the id attributes were not automatically generated by Goldmark using WithAutoHeadingID. The issue occurred because NewDefaultHTMLWebClientConfig, which initializes this feature, was no longer being used.

@alexiscolin alexiscolin requested a review from gfanton January 17, 2025 07:31
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 17, 2025
@alexiscolin
Copy link
Member Author

@gfanton You might want to consider using NewDefaultHTMLWebClientConfig again, though.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 17, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: alexiscolin/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@alexiscolin alexiscolin marked this pull request as draft January 17, 2025 07:32
@alexiscolin alexiscolin marked this pull request as ready for review January 17, 2025 07:36
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 70.76923% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/pkg/gnoweb/webclient_html.go 73.68% 10 Missing and 5 partials ⚠️
gno.land/pkg/gnoweb/app.go 50.00% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@alexiscolin alexiscolin changed the title fix(gnoeb): realms titles missing id and toc anchors fix(gnoweb): titles missing id and toc anchors Jan 17, 2025
@alexiscolin alexiscolin added the 🌍 gnoweb Issues & PRs related to gnoweb and render label Jan 17, 2025
@gfanton
Copy link
Member

gfanton commented Jan 17, 2025

@alexiscolin i've applied some changes and a test to avoid regression directly on your branch: alexiscolin#1

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Jan 17, 2025
feat: centralize format logic inside webclient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌍 gnoweb Issues & PRs related to gnoweb and render in focus Core team is prioritizing this work 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants