-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnoweb): titles missing id and toc anchors #3538
base: master
Are you sure you want to change the base?
Conversation
@gfanton You might want to consider using |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
@alexiscolin i've applied some changes and a test to avoid regression directly on your branch: alexiscolin#1 |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
feat: centralize format logic inside webclient
Fixes issues related to the table of contents in gnoweb (realms). The links were not working because the
id
attributes were not automatically generated by Goldmark usingWithAutoHeadingID
. The issue occurred becauseNewDefaultHTMLWebClientConfig
, which initializes this feature, was no longer being used.