Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autocounterd): fix ShortHelp, improve error messages #3504

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Jan 13, 2025

Per title.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 13, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details (checked by @thehowl)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: mdqst/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 14, 2025
@thehowl
Copy link
Member

thehowl commented Jan 14, 2025

Hey, thank you, but your private profile and your 300 forks to crypto projects quite clearly indicate that you're airdrop farming. See this section: https://github.com/gnolang/gno/blob/master/CONTRIBUTING.md#avoding-unhelpful-contributions

@thehowl thehowl closed this Jan 14, 2025
@mdqst
Copy link
Contributor Author

mdqst commented Jan 15, 2025

thehowl, I just love helping projects and trying to contribute.

@thehowl thehowl reopened this Jan 15, 2025
@thehowl
Copy link
Member

thehowl commented Jan 15, 2025

Okay, I'm willing to re-open because you objected to this and the contribution seems to be higher quality than the rest I've seen from other airdrop farmers, though I am highly sceptical of contributors with a private profile. I do wonder why your PR description is completely unrelated from the patch itself, which only does a few minor improvements to misc/autocounterd, a relatively minor component which is likely to be deleted, anyway.

In any case, updating the PR title and description and merging. Please consider, if possible, making your profile public for transparency (though it is not a requirement for further contributions); and next time, make sure your PR title and description actually match the changes you're doing.

@thehowl thehowl changed the title fix: error handling and improve code clarity Update cmd_start.go chore(autocounterd): fix ShortHelp, improve error messages Jan 15, 2025
@thehowl thehowl merged commit 3fa9940 into gnolang:master Jan 15, 2025
19 checks passed
@notJoon notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 16, 2025
@mdqst
Copy link
Contributor Author

mdqst commented Jan 16, 2025

Thank you for the recommendations, I’m really happy to have contributed to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants