fix: handle p2p events properly in cluster tests #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
sw360cab
approved these changes
Jan 7, 2025
albttx
pushed a commit
that referenced
this pull request
Jan 10, 2025
## Description This PR fixes an issue with the p2p event stream where events can be missed due to not being actively scooped from the channel, causing tests to hang. This non-blocking nature is by design, the p2p event stream should be non-blocking for subscribers at all times when new events are added. The PR increases the buffer size for events (from 1 to a reasonable value). For larger event loads, subscribers can handle channel draining caller side without any issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the p2p event stream where events can be missed due to not being actively scooped from the channel, causing tests to hang. This non-blocking nature is by design, the p2p event stream should be non-blocking for subscribers at all times when new events are added.
The PR increases the buffer size for events (from 1 to a reasonable value). For larger event loads, subscribers can handle channel draining caller side without any issues