-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gno.land): improve test speed #3396
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: gfanton <[email protected]>
c5c5faa
to
ddef133
Compare
Signed-off-by: gfanton <[email protected]>
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work for the speed up 👏
I almost can't believe we can run this integration suite so quickly now (< 1 min).
This isn't a step forward, but an olympic leap :)
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Just a note that running the integration package tests generates a cc @gfanton |
Signed-off-by: gfanton <[email protected]>
@zivkovicmilos After some tests, I didn't have the |
This PR significantly improves the testing speed of the
gno.land
integration tests. This is mainly achieved through two changes:As a result of this PR, all the
gno.land
tests now run on the CI in approximately3m
, compared to about20m
on the master branch.Once we can run multiple nodes in the same process, we will simplify this part of the codebase. In the meantime, if you are brave enough to try to fix this, you can attempt to run all the tests in memory AND in parallel (and watch them fail).
NO_SEQ_TS=true INMEMORY_TS=true go test -v -count=1 ./pkg/integration/...