chore: Upgrade go.uber.org/zap/exp to v0.3.0 (to fix dependabot upgrades) #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft0
added
the
review/triage-pending
github-actions
bot
added
the
📦 ⛰️ gno.land
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
chore/upgrade-to-zap/exp-3.0
branch
from
366230d to
7590198
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
thehowl
approved these changes
Dec 20, 2024
albttx
pushed a commit
that referenced
this pull request
Jan 10, 2025
…des) (#3378) Dependabot PRs #3306 and #3343 want to (among other things) upgrade go.uber.org/zap/exp from v0.2.0 to v0.3.0 . This causes a nil pointer exception because of [this code](https://github.com/gnolang/gno/blob/master/gno.land/pkg/log/zap.go#L74): ``` return slog.New(zapslog.NewHandler(logger.Core(), nil)) ``` The problem is that go.uber.org/zap/exp v0.2.0 has: ``` func NewHandler(core zapcore.Core, opts *HandlerOptions) *Handler ``` but v0.3.0 has: ``` func NewHandler(core zapcore.Core, opts ...HandlerOption) *Handler ``` Thus, it views the nil second argument as a nil `HandlerOption`. The fix is to simply remove the second argument in the call to `NewHandler`. When this is merged, we can tell dependabot to rebase the original PRs and the CI tests should pass. Signed-off-by: Jeff Thompson <[email protected]> Co-authored-by: Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot PRs #3306 and #3343 want to (among other things) upgrade go.uber.org/zap/exp from v0.2.0 to v0.3.0 . This causes a nil pointer exception because of this code:
The problem is that go.uber.org/zap/exp v0.2.0 has:
but v0.3.0 has:
Thus, it views the nil second argument as a nil
HandlerOption. The fix is to simply remove the second argument in the call toNewHandler.When this is merged, we can tell dependabot to rebase the original PRs and the CI tests should pass.