Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: validate genesis.json #3170

Merged
merged 11 commits into from
Nov 26, 2024
Merged

ci: validate genesis.json #3170

merged 11 commits into from
Nov 26, 2024

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Nov 20, 2024 •
edited
Loading

Description

--
resolves #3108

This pr implements ci which will be run when certain pr changes genesis.json

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Nov 21, 2024
@r3v4s r3v4s marked this pull request as ready for review November 22, 2024 04:47
@r3v4s r3v4s requested a review from zivkovicmilos November 22, 2024 04:47
@r3v4s
Copy link
Contributor Author

r3v4s commented Nov 22, 2024

@zivkovicmilos Every thing is done except for bench.
Because of default mempool size 5000, bench ins't working well.

I'll update it again when I found out how to bench thing in smooth way.

@Kouteki Kouteki added this to the 🚀 Mainnet launch milestone Nov 22, 2024
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 22, 2024
zivkovicmilos
zivkovicmilos approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Pinging @sw360cab for a final screen

@sw360cab sw360cab merged commit 95450ff into gnolang:master Nov 26, 2024
102 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/genesis-verify-ci branch November 26, 2024 10:34
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 29, 2024
@gnolang gnolang deleted a comment from Gno2D2 Dec 2, 2024
@Kouteki Kouteki mentioned this pull request Dec 9, 2024
Open
r3v4s added a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
@r3v4s
ci: validate genesis.json (gnolang#3170)
bc4545b
albttx pushed a commit that referenced this pull request Jan 10, 2025
@r3v4s @albttx
ci: validate genesis.json (#3170)
d434852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@ltzmaxwell ltzmaxwell ltzmaxwell left review comments

@mazzy89 mazzy89 mazzy89 left review comments

@sw360cab sw360cab sw360cab approved these changes

Assignees

@r3v4s r3v4s

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
🤝🏻 Partner: Onbloc
Status: Done
🧙‍♂️gno.land core team
Archived in project
Milestone
🚀 Mainnet beta launch
Development

Successfully merging this pull request may close these issues.

Create CI for validating a network deployment genesis.json
6 participants
@r3v4s @sw360cab @mazzy89 @ltzmaxwell @zivkovicmilos @Kouteki