Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: branch stmts #3043

Merged
merged 12 commits into from
Nov 18, 2024
Merged

fix: branch stmts #3043

merged 12 commits into from
Nov 18, 2024

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Oct 29, 2024

Adds validation for break, continue and fallthrough to disallow invalid code.
Moves existing validation from the runtime to the preprocessor.

Closes #2973

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 29, 2024
@petar-dambovaliev petar-dambovaliev changed the title Bug: fix switch branch stmts fix: switch branch stmts Oct 29, 2024
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.73%. Comparing base (4f27a57) to head (919f650).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
- Coverage   63.77%   63.73%   -0.05%     
==========================================
  Files         548      548              
  Lines       78681    78695      +14     
==========================================
- Hits        50180    50157      -23     
- Misses      25117    25148      +31     
- Partials     3384     3390       +6     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (+0.62%) ⬆️
contribs/gnofaucet 15.77% <ø> (+0.94%) ⬆️
gno.land 73.62% <ø> (ø)
gnovm 67.93% <100.00%> (+<0.01%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 62.31% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Show resolved Hide resolved
@Kouteki Kouteki added this to the 🚀 Mainnet launch milestone Nov 10, 2024
@petar-dambovaliev petar-dambovaliev changed the title fix: switch branch stmts fix: branch stmts Nov 10, 2024
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@petar-dambovaliev petar-dambovaliev merged commit 0246761 into master Nov 18, 2024
135 checks passed
@petar-dambovaliev petar-dambovaliev deleted the 2973 branch November 18, 2024 09:08
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 29, 2024
@gnolang gnolang deleted a comment from Gno2D2 Dec 2, 2024
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
Adds validation for `break`, `continue` and `fallthrough` to disallow
invalid code.
Moves existing validation from the runtime to the preprocessor.

Closes gnolang#2973
albttx pushed a commit that referenced this pull request Jan 10, 2025
Adds validation for `break`, `continue` and `fallthrough` to disallow
invalid code.
Moves existing validation from the runtime to the preprocessor.

Closes #2973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

can break out of a self-executing closure
4 participants