Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel): Open Telemetry metrics fixed and provided with demo example #3038

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

sw360cab
Copy link
Contributor

  • Redefine and cleanup Open Telemetry metrics types and usage
  • Rehauled demo example adding a minimal sample of RCP + Validator Node

@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the tm2/gno.land part, haven't reviewed misc/telemetry.

gno.land/pkg/sdk/vm/handler.go Show resolved Hide resolved
@thehowl
Copy link
Member

thehowl commented Nov 6, 2024

maybe @zivkovicmilos can take a second look / merge.

@zivkovicmilos zivkovicmilos self-requested a review November 6, 2024 17:50
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

misc/telemetry/docker-compose.yml Show resolved Hide resolved
@sw360cab sw360cab merged commit 549da06 into gnolang:master Nov 21, 2024
100 of 101 checks passed
@sw360cab sw360cab deleted the feat/otel branch November 21, 2024 14:39
@sw360cab
Copy link
Contributor Author

sw360cab commented Dec 3, 2024

Partially solves #2434 for the metric part

r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
…ple (gnolang#3038)

* Redefine and cleanup Open Telemetry metrics types and usage
* Rehauled demo example adding a minimal sample of RCP + Validator Node
albttx pushed a commit that referenced this pull request Jan 10, 2025
…ple (#3038)

* Redefine and cleanup Open Telemetry metrics types and usage
* Rehauled demo example adding a minimal sample of RCP + Validator Node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants