-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(otel): Open Telemetry metrics fixed and provided with demo example #3038
Conversation
sw360cab
commented
Oct 28, 2024
- Redefine and cleanup Open Telemetry metrics types and usage
- Rehauled demo example adding a minimal sample of RCP + Validator Node
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the tm2/gno.land part, haven't reviewed misc/telemetry.
maybe @zivkovicmilos can take a second look / merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Partially solves #2434 for the metric part |
…ple (gnolang#3038) * Redefine and cleanup Open Telemetry metrics types and usage * Rehauled demo example adding a minimal sample of RCP + Validator Node
…ple (#3038) * Redefine and cleanup Open Telemetry metrics types and usage * Rehauled demo example adding a minimal sample of RCP + Validator Node