fix: global var dependencies #2077

petar-dambovaliev · 2024-05-13T02:05:16Z

fixes this by adding missing logic in in findUndefined2

codecov · 2024-05-13T12:16:45Z

Codecov Report

Attention: Patch coverage is 53.01455% with 226 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/preprocess.go	53.01%	209 Missing and 17 partials ⚠️

📢 Thoughts on this report? Let us know!

zivkovicmilos

Left some nitty comments 🙏

Overall looks good, thank you for the fix 🙏

gnovm/pkg/gnolang/preprocess.go

thehowl

Please also add more tests to check for different cases, thanks!

Gno2D2 · 2024-12-09T22:02:29Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

outdated

Kouteki · 2025-01-16T13:28:15Z

@petar-dambovaliev I've moved this PR to draft until it's ready for review.

petar-dambovaliev · 2025-01-16T22:44:03Z

Only codecov failing. Its ready. @Kouteki

ltzmaxwell

LGTM! A few requests, mostly regarding comments, so we can avoid reviewing this as a brand new PR each time. :)

ltzmaxwell · 2025-01-17T13:04:28Z

gnovm/pkg/gnolang/preprocess.go

+func getGlobalValueRef(sb BlockNode, store Store, n Name) *TypedValue {
+	sbb := sb.GetStaticBlock()
+	idx, ok := sb.GetLocalIndex(n)
+	bb := &sb.GetStaticBlock().Block
+	bp := sb.GetParentNode(store)
+
+	for {
+		if ok && sbb.Types[idx] != nil && (bp == nil || bp.GetParentNode(store) == nil) {


Suggested change

func getGlobalValueRef(sb BlockNode, store Store, n Name) *TypedValue {

sbb := sb.GetStaticBlock()

idx, ok := sb.GetLocalIndex(n)

bb := &sb.GetStaticBlock().Block

bp := sb.GetParentNode(store)

for {

if ok && sbb.Types[idx] != nil && (bp == nil || bp.GetParentNode(store) == nil) {

func getGlobalValueRef(sb BlockNode, store Store, n Name) *TypedValue {

sbb := sb.GetStaticBlock()

bb := &sb.GetStaticBlock().Block

bp := sb.GetParentNode(store)

idx, exist := sb.GetLocalIndex(n)

for {

if exist && sbb.Types[idx] != nil && (bp == nil || bp.GetParentNode(store) == nil) {

ltzmaxwell · 2025-01-17T13:06:14Z

gnovm/pkg/gnolang/preprocess.go

+	}
+}
+
+func findUndefinedGlobal(store Store, last BlockNode, x Expr, t Type) (un Name) {


will findUndefinedFromGlobal be more directional?

ltzmaxwell · 2025-01-17T13:08:34Z

gnovm/pkg/gnolang/preprocess.go

+
+// finds the next undefined identifier and returns it if it is global
+func findUndefined2SkipLocals(store Store, last BlockNode, x Expr, t Type) Name {
+	name := findUndefinedGlobal(store, last, x, t)


as the base logic of the PR, please add comments to this function. to better illustrate the searching logic:
for my understanding: searching from initialized global -> uninitialized global decls -> local...

ltzmaxwell · 2025-01-17T13:09:51Z

gnovm/pkg/gnolang/preprocess.go

+	if _, _, ok := pkg.FileSet.GetDeclForSafe(name); !ok {
+		return ""
+	}


also need comments here.

ltzmaxwell · 2025-01-17T13:10:06Z

gnovm/pkg/gnolang/preprocess.go

+		return ""
+	}
+
+	isLocal := existsLocal(name, last)


ltzmaxwell · 2025-01-17T13:26:45Z

gnovm/pkg/gnolang/preprocess.go

+	bp := sb.GetParentNode(store)
+
+	for {
+		if ok && sbb.Types[idx] != nil && (bp == nil || bp.GetParentNode(store) == nil) {


sbb.Types[idx] != nil implies it's defined rather than predefined, right? please add a comment here.

ltzmaxwell · 2025-01-17T13:30:47Z

gnovm/pkg/gnolang/preprocess.go

+		for {
+			currNames := curr.GetBlockNames()
+
+			for _, currName := range currNames {


searching (only)by name implies predefined(only names, no types) is good, right? please also add comment here.

ltzmaxwell · 2025-01-17T13:41:04Z

and what we do with the codecov? @petar-dambovaliev @zivkovicmilos

ltzmaxwell · 2025-01-17T13:54:35Z

gnovm/pkg/gnolang/preprocess.go

+	return ""
+}
+
+func getGlobalValueRef(sb BlockNode, store Store, n Name) *TypedValue {


better make it a method like the existing one:
func (sb *StaticBlock) GetValueRef(store Store, n Name, skipPredefined bool),

ltzmaxwell · 2025-01-17T14:15:15Z

gnovm/pkg/gnolang/preprocess.go

+	bp := sb.GetParentNode(store)
+
+	for {
+		if ok && sbb.Types[idx] != nil && (bp == nil || bp.GetParentNode(store) == nil) {


if it must reach bp == nil to make sure it's global, then bp.GetParentNode(store) == nil is not needed/reachable.

gnovm/pkg/gnolang/preprocess.go

ltzmaxwell · 2025-01-17T14:49:48Z

Perhaps the logic in findUndefined2SkipLocals could be simplified further by modifying it to only find the name without type (which would imply that the predefined name is enough). In that case, GetDeclForSafe would no longer be necessary, correct?

ltzmaxwell · 2025-01-17T15:45:41Z

Perhaps the logic in findUndefined2SkipLocals could be simplified further by modifying it to only find the name without type (which would imply that the predefined name is enough). In that case, GetDeclForSafe would no longer be necessary, correct?

maybe the difference won't be big, just some food for thoughts.

petar-dambovaliev · 2025-01-17T17:39:55Z

Perhaps the logic in findUndefined2SkipLocals could be simplified further by modifying it to only find the name without type (which would imply that the predefined name is enough). In that case, GetDeclForSafe would no longer be necessary, correct?

maybe the difference won't be big, just some food for thoughts.

At first, i tried having a single function but it became too many changes and too messy

github-actions bot assigned petar-dambovaliev May 13, 2024

github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 13, 2024

zivkovicmilos added this to the 🏗4️⃣ test4.gno.land milestone May 13, 2024

petar-dambovaliev marked this pull request as ready for review May 13, 2024 12:16

petar-dambovaliev requested review from jaekwon, moul, piux2, deelawn, thehowl and mvertes as code owners May 13, 2024 12:16

zivkovicmilos approved these changes May 15, 2024

View reviewed changes

zivkovicmilos requested a review from ajnavarro May 15, 2024 13:28

michelleellen mentioned this pull request May 22, 2024

Minutes: Public Dev Calls [every Wednesday] gnolang/meetings#37

Open

thehowl requested review from ltzmaxwell May 27, 2024 11:19

thehowl reviewed May 27, 2024

View reviewed changes

gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved

thehowl requested changes May 27, 2024

View reviewed changes

deelawn mentioned this pull request Jun 6, 2024

Minutes: GitHub Review Meetings [every Thursday] gnolang/meetings#18

Open

3 tasks

petar-dambovaliev requested review from a team, gfanton and leohhhn as code owners June 12, 2024 13:02

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jun 12, 2024

petar-dambovaliev force-pushed the vardeps branch from c7365aa to 813b7e1 Compare June 12, 2024 13:12

petar-dambovaliev requested a review from thehowl June 12, 2024 13:18

petar-dambovaliev added 3 commits December 9, 2024 23:28

save

b134378

save

e553307

save

dea7c86

petar-dambovaliev requested a review from ltzmaxwell December 13, 2024 23:22

petar-dambovaliev added 2 commits December 14, 2024 00:39

save

1b1868f

Merge branch 'master' into vardeps

5d8dd86

petar-dambovaliev requested review from ajnavarro and deelawn December 14, 2024 00:13

Kouteki marked this pull request as draft January 16, 2025 13:26

Kouteki removed request for ajnavarro and deelawn January 16, 2025 13:29

petar-dambovaliev added 4 commits January 16, 2025 14:47

Merge branch 'master' into vardeps

f513f14

save

9152ea8

save

4913c76

save

2d3f37c

petar-dambovaliev marked this pull request as ready for review January 16, 2025 22:24

petar-dambovaliev requested a review from ajnavarro January 16, 2025 22:47

ltzmaxwell approved these changes Jan 17, 2025

View reviewed changes

ltzmaxwell reviewed Jan 17, 2025

View reviewed changes

petar-dambovaliev unassigned aeddi Jan 18, 2025

Merge branch 'master' into vardeps

9aee71d

petar-dambovaliev enabled auto-merge (squash) January 18, 2025 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: global var dependencies #2077

fix: global var dependencies #2077

petar-dambovaliev commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading

zivkovicmilos left a comment

thehowl left a comment

Gno2D2 commented Dec 9, 2024 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Can be checked by

Kouteki commented Jan 16, 2025

petar-dambovaliev commented Jan 16, 2025 •

edited

Loading

ltzmaxwell left a comment

ltzmaxwell Jan 17, 2025

ltzmaxwell Jan 17, 2025

ltzmaxwell Jan 17, 2025

ltzmaxwell Jan 17, 2025

ltzmaxwell Jan 17, 2025

ltzmaxwell Jan 17, 2025 •

edited

Loading

ltzmaxwell Jan 17, 2025 •

edited

Loading

ltzmaxwell commented Jan 17, 2025

ltzmaxwell Jan 17, 2025

ltzmaxwell Jan 17, 2025

ltzmaxwell commented Jan 17, 2025

ltzmaxwell commented Jan 17, 2025

petar-dambovaliev commented Jan 17, 2025

fix: global var dependencies #2077

Are you sure you want to change the base?

fix: global var dependencies #2077

Conversation

petar-dambovaliev commented May 13, 2024 • edited Loading

codecov bot commented May 13, 2024 • edited Loading

Codecov Report

zivkovicmilos left a comment

Choose a reason for hiding this comment

thehowl left a comment

Choose a reason for hiding this comment

Gno2D2 commented Dec 9, 2024 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Can be checked by

Kouteki commented Jan 16, 2025

petar-dambovaliev commented Jan 16, 2025 • edited Loading

ltzmaxwell left a comment

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

ltzmaxwell commented Jan 17, 2025

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell Jan 17, 2025

Choose a reason for hiding this comment

ltzmaxwell commented Jan 17, 2025

ltzmaxwell commented Jan 17, 2025

petar-dambovaliev commented Jan 17, 2025

petar-dambovaliev commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading

Gno2D2 commented Dec 9, 2024 •

edited

Loading

petar-dambovaliev commented Jan 16, 2025 •

edited

Loading

ltzmaxwell Jan 17, 2025 •

edited

Loading

ltzmaxwell Jan 17, 2025 •

edited

Loading