chore: fixup (tmp)

Signed-off-by: moul <[email protected]>
gnolang · Oct 11, 2024 · 4c04221 · 4c04221
1 parent 8b6acde
commit 4c04221
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 13 deletions.
diff --git a/gno.land/cmd/gnoland/testdata/params.txtar b/gno.land/cmd/gnoland/testdata/params.txtar
@@ -2,17 +2,22 @@
 
 gnoland start
 
-# XXX: create a non-sys package that should fail
+# XXX: create a non-sys package that should fail?
 
 gnokey maketx addpkg -pkgdir $WORK/setter -pkgpath gno.land/r/sys/setter -gas-fee 1000000ugnot -gas-wanted 100000000 -broadcast -chainid=tendermint_test test1
 
 gnokey query params/vm/gno.land/r/sys/setter.foo.string
-stdout ''
+stdout 'data: $'
 
 gnokey maketx call -pkgpath gno.land/r/sys/setter -func SetFoo -args foo1 -gas-fee 1000000ugnot -gas-wanted 10000000 -broadcast -chainid=tendermint_test test1
 
 gnokey query params/vm/gno.land/r/sys/setter.foo.string
-#stdout ''
+stdout 'data: "foo1"'
+
+gnokey maketx call -pkgpath gno.land/r/sys/setter -func SetFoo -args foo2 -gas-fee 1000000ugnot -gas-wanted 10000000 -broadcast -chainid=tendermint_test test1
+
+gnokey query params/vm/gno.land/r/sys/setter.foo.string
+stdout 'data: "foo2"'
 
 -- setter/setter.gno --
 package setter

diff --git a/gno.land/pkg/sdk/vm/builtins.go b/gno.land/pkg/sdk/vm/builtins.go
@@ -78,7 +78,7 @@ func NewSDKParams(vmk *VMKeeper, ctx sdk.Context) *SDKParams {
 
 func (prm *SDKParams) SetString(key, value string) {
 	// if !prm.vmk.prmk.Has(prm.ctx, key) {
-	if !prm.vmk.prmk.HasTypeKey(key) {
+	if !prm.vmk.prmk.HasTypeKey(key) { // XXX: bad workaround, maybe we should have a dedicated "dynamic keeper" allowing to create keys on the go?
 		prm.vmk.prmk.RegisterType(params.NewParamSetPair(key, "", validateNoOp))
 	}
 	prm.vmk.prmk.Set(prm.ctx, key, value)

diff --git a/tm2/pkg/sdk/params/handler.go b/tm2/pkg/sdk/params/handler.go
@@ -42,22 +42,16 @@ func (bh paramsHandler) Query(ctx sdk.Context, req abci.RequestQuery) (res abci.
 func (bh paramsHandler) queryParam(ctx sdk.Context, req abci.RequestQuery) (res abci.ResponseQuery) {
 	// parse key from path.
 	key := thirdPartWithSlashes(req.Path)
-  println("@@@@@@@@@@@@@@@@@@", key)
 	if key == "" {
 		res = sdk.ABCIResponseQueryFromError(
 			std.ErrUnknownRequest("param key is empty"))
 	}
 
-	// XXX: validate
+	// XXX: validate?
 
-/*
-//  var out interface{}
-  var out string
-  bh.params.GetIfExists(ctx, key, &out)
-  println("OUT")
-  println(out)
-  */
+	val := bh.params.GetRaw(ctx, key)
 
+	res.Data = val
 	return
 }