added "deadLetter" to the list of valid function properties. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess deploy" would not work without this.
|
I am also getting the configuration warning message: Can this pull request be merged? |
rachnareddyg
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
looks correct according to serverless documentation: https://www.serverless.com/framework/docs/guides/plugins/custom-configuration#function-properties-via-definefunctionproperties
dxd1
added a commit
to epsyhealth/serverless-plugin-lambda-dead-letter
that referenced
this pull request
Mar 31, 2022
ivantoniev
added a commit
to BloomAndWild/serverless-plugin-lambda-dead-letter-v2-compat
that referenced
this pull request
Feb 17, 2023
We want to upgrade to a newer serverless version, to do that, we need to make this change to work with the new serverless dsl. This was taken from the original repo which is no longer maintained and the proposed fix was not merged. gmetzker#44
|
Hi, why isn't this PR merged? |
|
It would be great to merge this change and push a new version in npmjs. That could prevent a new version into npmjs. |
|
@amilliken-bb Maybe you need to add @gmetzker as a reviewer too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the following error:
Configuration error at 'functions.<functionName>': unrecognized property 'deadLetter'