Minor tox.ini improvement: use base = mypy
#1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring a `base` environment allows you to declare a parallel environment to an existing one with some settings overridden. This lets us avoid the generative environment listing syntax (slightly obscure as a feature, not everyone knows about it) and having two `commands` lists fully differentiated by a factor. The config here is 100% equivalent to what we had before, but is easier to read and understand for developers less immersed in tox.
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
MaxTueckeGlobus
as code owners
kurtmckee
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring a
baseenvironment allows you to declare a parallelenvironment to an existing one with some settings overridden. This
lets us avoid the generative environment listing syntax (slightly
obscure as a feature, not everyone knows about it) and having two
commandslists fully differentiated by a factor.The config here is 100% equivalent to what we had before, but is
easier to read and understand for developers less immersed in tox.
📚 Documentation preview 📚: https://globus-sdk-python--1119.org.readthedocs.build/en/1119/