Bugfix: allow_domains vs allowed_domains

I've confirmed with the team that this was always incorrect -- there was never a version which accepted `allow_domains`.
globus · Dec 17, 2024 · 1d6b937 · 1d6b937
1 parent fa22c64
commit 1d6b937
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst b/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst
@@ -0,0 +1,6 @@
+Fixed
+~~~~~
+
+- Fix a bug in ``StorageGatewayDocument`` which stored any ``allowed_domains``
+  argument under an ``"allow_domains"`` key instead of the correct key,
+  ``"allowed_domains"``. (:pr:`NUMBER`)
diff --git a/src/globus_sdk/services/gcs/data/storage_gateway.py b/src/globus_sdk/services/gcs/data/storage_gateway.py
@@ -78,7 +78,7 @@ def __init__(
             root=root,
         )
         self._set_optstrlists(
-            allow_domains=allowed_domains,
+            allowed_domains=allowed_domains,
             users_allow=users_allow,
             users_deny=users_deny,
         )