Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the (short) docker container ID to the SkyDNS2 registration to allow for multiple containers with the same name and service id.
I faced the issue where, when registering scaled services with the same service name (say; exampleimage) and service id (say: acceptance) would result in only one registration that had been overwritten because of the same service path.
By means of this pull request I've added the container id to the service path to differentiate between these scaled containers and allow the SkyDNS resolving to work correctly. Since SkyDNS uses wildcard resolving (see: https://github.com/skynetservices/skydns#wildcards) this pull request won't change behaviour and all examples still remain valid. It does fix the before mentioned bug however and caters for scaling containers using the same image + service label combination, a pattern commonly see in AWS ECS.
Example:
Before the pull request:
2 images with same name + service id would result in the following single SkyDNS registration:
After the pull request change:
2 images with same name + service id would result in the following multiple SkyDNS registrations: