Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: run sysroot discovery once #18484

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Rust: run sysroot discovery once #18484

merged 1 commit into from
Jan 14, 2025

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jan 13, 2025

This shows a marginal performance gain (~2% average on DCA).

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jan 13, 2025
@redsun82 redsun82 marked this pull request as ready for review January 14, 2025 07:59
@redsun82 redsun82 requested review from Copilot and aibaars January 14, 2025 07:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

rust/extractor/src/main.rs:165

  • Ensure that the new cwd function and the modified to_cargo_config function are covered by tests.
fn cwd() -> anyhow::Result<AbsPathBuf> {

rust/extractor/src/config.rs:89

  • The new behavior introduced by the sysroot and sysroot_src variables in the to_cargo_config function is not covered by tests. Please add tests to ensure this behavior is properly tested.
pub fn to_cargo_config(&self, dir: &AbsPath) -> CargoConfig {

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@redsun82 redsun82 merged commit 23612b4 into main Jan 14, 2025
13 checks passed
@redsun82 redsun82 deleted the redsun82/rust-discover-once branch January 14, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants