Filter registry credentials by language #2680
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
marcogario
force-pushed
the
marcogario/filter_registries
branch
2 times, most recently
from
4263e13 to
0e7e3db
Compare
marcogario
force-pushed
the
marcogario/filter_registries
branch
from
0e7e3db to
e02d65a
Compare
marcogario
force-pushed
the
marcogario/filter_registries
branch
from
d9e8b07 to
de0f9cf
Compare
src/start-proxy-action.ts
Outdated
| @@ -17,6 +17,12 @@ const PROXY_USER = "proxy_user"; | |||
| const KEY_SIZE = 2048; | |||
| const KEY_EXPIRY_YEARS = 2; | |||
|
|
|||
| const LANGUAGE_TO_REGISTRY_TYPE = { | |||
| "java-kotlin": "maven_repository", | |||
There was a problem hiding this comment.
Should you add kotlin as a standalone language?
Also there is languages.ts, which is where we've traditionally added language-specific logic. I think I'd prefer to move this declaration to that file.
There was a problem hiding this comment.
I've pushed a commit where this logic better integrates with languages.ts, by reusing the Language type defined there.
I am 50/50 on whether we should move this map there. The main reason against doing so is that this information is really only useful for the proxy action and even the names of the registry types are fairly arbitrary and dependent on the specifics of the proxy binary. WDYT?
There was a problem hiding this comment.
I'm fine if the logic doesn't go into language.ts.
marcogario
force-pushed
the
marcogario/filter_registries
branch
from
f33e08c to
529f92f
Compare
marcogario
force-pushed
the
marcogario/filter_registries
branch
from
529f92f to
31d11b1
Compare
| actions: "", | ||
| cpp: "", | ||
| go: "", | ||
| swift: "", |
There was a problem hiding this comment.
nit:
| actions: "", | |
| cpp: "", | |
| go: "", | |
| swift: "", | |
| actions: undefined, | |
| cpp: undefined, | |
| go: undefined, | |
| swift: undefined, |
| const registryTypeForLanguage = language | ||
| ? LANGUAGE_TO_REGISTRY_TYPE[language] | ||
| : undefined; |
There was a problem hiding this comment.
nit: If you apply the suggestion above, then this becomes simpler:
| const registryTypeForLanguage = language | |
| ? LANGUAGE_TO_REGISTRY_TYPE[language] | |
| : undefined; | |
| const registryTypeForLanguage = LANGUAGE_TO_REGISTRY_TYPE[language]; |
There was a problem hiding this comment.
I still need the check on language itself, though.
Introduce the
languageparameter for the start-proxy action so we know which credentials we should use.By specifying the language with disambiguating cases where the same registry has distinct credentials. For example, in Artifactory it is possible to use a token that is scoped to the nuget feed, while the maven repository uses the username/password combination.
Merge / deployment checklist