-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for downloading the chromedriver after installation #278
Conversation
The only additional thing that I think may be beneficial to have as a part of this is an exported |
Wow, this is a large PR, I'll check it out on the weekend. |
@giggio Have you had the chance to look at this PR? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@giggio Did you ever get a chance to look at this? |
would love to get this merged as well! |
+1 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Using the
.download
async function, we can now do things likeawait chromedriver.download();
before any tests get run.
Additionally, some options are supported.
We can pass in
download_version
orcdn_url
like such:await chromedriver.download({cdn_url: "http://localhost", download_version: 84});
download_version
is able to be passed in as the full version of chrome ("84.0.4147.105"
) or just the major version (84
)I believe this is the functionality requested by @HaimBendanan in issue #256