-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename info.py.in to info.py #1141
base: master
Are you sure you want to change the base?
Conversation
File naming error resulting in test failures
This causes the error 'GTG/core/meson.build:25:10: ERROR: File info.py.in does not exist'. To fix this, change 'info.py.in' to 'info.py' on line 26 of that file. After this change, 'bash launch.sh' will work with automated tests and 'precommit'. |
As a follow-up to issue getting-things-gnome#1141, we've successfully renamed info.py.in to info.py. This change has resolved the automated test failures we were experiencing.
I don't like this solution because it removes the indication that it is a file to be post-processed. If anything, tests should just work with the build-installed version since we don't support running the project in-place anyway (which sound what you are trying to do), unless we (or someone else) make the project runnable in-place. PR #1142 depends on this commit, so you should just combine both into one PR (you could add the commit to this repo, but it seems you are editing from the Github Web UI (because of the branch name) and I am not sure if it can do that.) |
Yes, that's not actually a file naming error. The problem is that meson needs to be run before running the tests. That will create process the
It's kind of annoying to have to do that. It gets in the way of quick iteration when writing code and tests in parallel. So on my local machine, after running meson once, I copied the resulting
This is probably worth a subsection under "Setting up a development environment" in the README. I'll look into that. |
File naming error resulting in test failures