fix(explore): Search type disagreements between snql and rpc #83518
+202
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snql and RPC disagree on the search type of a few fields. Make them all numbers. Will try to update to RPC so this doesn't happen again as that will be the source of truth in the future.
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83518 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.01%
==========================================
Files 9406 9408 +2
Lines 537384 537562 +178
Branches 21160 21160
==========================================
+ Hits 470371 470602 +231
+ Misses 66668 66615 -53
Partials 345 345 |
Zylphrex
deleted the
txiao/fix/search-type-disagreements-between-snql-and-rpc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snql and RPC disagree on the search type of a few fields. Make them all numbers. Will try to update to RPC so this doesn't happen again as that will be the source of truth in the future.