Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set style properties directly in mutation #211
base: sentry-v2
Are you sure you want to change the base?
fix: Set style properties directly in mutation #211
Changes from 1 commit
50b1309
1cdd944
47c0bc2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 369 in packages/rrweb/src/record/mutation.ts
GitHub Actions / ESLint Report Analysis
packages/rrweb/src/record/mutation.ts#L369
Check warning on line 375 in packages/rrweb/src/record/mutation.ts
GitHub Actions / ESLint Report Analysis
packages/rrweb/src/record/mutation.ts#L375
Check warning on line 37 in packages/rrweb/src/utils.ts
GitHub Actions / ESLint Report Analysis
packages/rrweb/src/utils.ts#L37
Check warning on line 121 in packages/rrweb/src/utils.ts
GitHub Actions / ESLint Report Analysis
packages/rrweb/src/utils.ts#L121
Check warning on line 134 in packages/rrweb/src/utils.ts
GitHub Actions / ESLint Report Analysis
packages/rrweb/src/utils.ts#L134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is this safe? Could styles not include colons in other places? Not 100% sure, just want to double check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will probably be an issue sooner or later, you're right