Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : redash docker image TAG #7280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Lee2532
Copy link

@Lee2532 Lee2532 commented Jan 15, 2025

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

The clean-all target in the Makefile still references the Docker image tag from a previous version, which may cause inconsistencies.

This PR updates the clean target to reference the latest version of the Docker image. Alternatively, we could consider referencing a specific version that matches the current TAG for better version control.

Changes:

  • Modified the Docker image tag reference in the clean-all target of the Makefile.

Please review and share your thoughts. Let me know if the current approach or referencing the corresponding TAG is preferred.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

issue : #7279

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (4ee53a9) to head (c4b7fa1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7280   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         163      163           
  Lines       13410    13410           
  Branches     1905     1905           
=======================================
  Hits         8585     8585           
  Misses       4490     4490           
  Partials      335      335           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant