Code

Port JavaRosa Scenario test suites#110

Code

Merged

eyelidlessness merged 140 commits intomaingetodk/web-forms:mainfrom jr-scenario-ports/kitchen-sinkgetodk/web-forms:jr-scenario-ports/kitchen-sinkCopy head branch name to clipboardMay 30, 2024

+135,278-879

Commits

Commits on May 28, 2024

• Scenario: prepare for possibility of also porting benchmarks

  Show description for 573b1f9
  eyelidlessness

  committed
  573b1f9

  Copy full SHA for 573b1f9

• Scenario: init distinction of JavaRosa-derived code from local

  Show description for 0637af5
  eyelidlessness

  committed
  0637af5

  Copy full SHA for 0637af5

• Break out Scenario client-traversal behavior

  eyelidlessness

  committed
  aac8fe2

  Copy full SHA for aac8fe2

• Break out engine form init from Scenario init

  eyelidlessness

  committed
  dc04975

  Copy full SHA for dc04975

• Migrate existing JR/Scenario tests to Vitest assertions

  Show description for 29b9ded
  eyelidlessness

  committed
  29b9ded

  Copy full SHA for 29b9ded

• More general engine traversal logic for existing Scenario functionality

  eyelidlessness

  committed
  18cdf4d

  Copy full SHA for 18cdf4d

• Increased consistency with JavaRosa “event” types

  Show description for 1a18f5a
  eyelidlessness

  committed
  1a18f5a

  Copy full SHA for 1a18f5a

• Temp: reject Root inititalization on uncaught error

  Show description for 9999559
  eyelidlessness

  committed
  9999559

  Copy full SHA for 9999559

• All current JavaRosa resources fixtures

  eyelidlessness

  committed
  4fb1a25

  Copy full SHA for 4fb1a25

• Support loading JavaRosa resources fixtures in Scenario.init

  eyelidlessness

  committed
  b930955

  Copy full SHA for b930955

• Port all JavaRosa tests from ChoiceNameTest.java

  eyelidlessness

  committed
  20724dd

  Copy full SHA for 20724dd

• Dispose of Scenario-internal reactive computations on test cleanup

  Show description for 78c9aab
  eyelidlessness

  committed
  78c9aab

  Copy full SHA for 78c9aab

• Better error when attempting to answer unresolvable question

  eyelidlessness

  committed
  6645558

  Copy full SHA for 6645558

• First select test - generalize absolute/relative body refs, choice assertions

  eyelidlessness

  committed
  6bd036e

  Copy full SHA for 6bd036e

• Second select test, improve choice assertions to handle array/iterable consistently

  eyelidlessness

  committed
  9a41ecd

  Copy full SHA for 9a41ecd

• Third select test, add Scenario.removeRepeat

  eyelidlessness

  committed
  5a61ae0

  Copy full SHA for 5a61ae0

• Final select test in region “Select from repeat”

  eyelidlessness

  committed
  6580f4d

  Copy full SHA for 6580f4d

• Better generalization of extending Vitest assertions

  Show description for 5f8acdb
  eyelidlessness

  committed
  5f8acdb

  Copy full SHA for 5f8acdb

• Move parameterization of absolute ref substitution…

  Show description for abc3d31
  eyelidlessness

  committed
  abc3d31

  Copy full SHA for abc3d31

• Port remainder of DynamicSelectUpdateTest.java

  eyelidlessness

  committed
  0ded764

  Copy full SHA for 0ded764

• Scenario select tests - Move “ported as of” comment up

  eyelidlessness

  committed
  2860f26

  Copy full SHA for 2860f26

• Porting FormDefSerializationTest.java - mostly skipped + context

  eyelidlessness

  committed
  d7ac19d

  Copy full SHA for d7ac19d

• Fix: correct Scenario fixture resources path

  eyelidlessness

  committed
  b824c66

  Copy full SHA for b824c66

• Port first correctness test from PredicateCachingTest.java

  eyelidlessness

  committed
  4e963fc

  Copy full SHA for 4e963fc

• Port next test from PredicateCachingTest, refine Scenario.createNewRepeat parameter

  eyelidlessness

  committed
  5e9fc30

  Copy full SHA for 5e9fc30

• Port remainder of PredicateCachingTest.java

  eyelidlessness

  committed
  ab62831

  Copy full SHA for ab62831

• Fix: don’t include non-relevant nodes as positional “event”s

  eyelidlessness

  committed
  e727cf1

  Copy full SHA for e727cf1

• Port all of RepeatTest.java

  eyelidlessness

  committed
  9d369b0

  Copy full SHA for 9d369b0

• Fix: include missed selecct1Dynamic DSL overload

  Show description for 6793031
  eyelidlessness

  committed
  6793031

  Copy full SHA for 6793031

• Port tests from PredicateCachingTest.java with correctness assertions…

  Show description for 617f6ed
  eyelidlessness

  committed
  617f6ed

  Copy full SHA for 617f6ed

• First SelectChoiceTest.java port + Scenario.getQuestionAtIndex

  eyelidlessness

  committed
  258b4ea

  Copy full SHA for 258b4ea

• Port JavaRosa SelectChoiceTest.java tests exercising SelectChoice.getChild`

  eyelidlessness

  committed
  b8d2aa8

  Copy full SHA for b8d2aa8

• Port remainder of SelectChoiceTest.java

  eyelidlessness

  committed
  c367551

  Copy full SHA for c367551

• Port SelectMultipleChoiceFilterTest.java

  eyelidlessness

  committed
  34f3151

  Copy full SHA for 34f3151

• Port SelectOneChoiceFilterTest.java

  eyelidlessness

  committed
  2c09eee

  Copy full SHA for 2c09eee

• First (top-down) TriggerableDagTest.java test port

  Show description for 893834e
  eyelidlessness

  committed
  893834e

  Copy full SHA for 893834e

• Second (top-down) TriggerableDagTest.java test port

  Show description for 59e60c1
  eyelidlessness

  committed
  59e60c1

  Copy full SHA for 59e60c1

• TriggerableDagTest.java - next cycle detection test, first big surprise failure!

  eyelidlessness

  committed
  3ce1a79

  Copy full SHA for 3ce1a79

• TriggerableDagTest.java - restructure grouping of parsing_forms_with_cycles_* tests

  eyelidlessness

  committed
  75aef32

  Copy full SHA for 75aef32

• TriggerableDagTest.java - port and supplement constraint cycles test

  eyelidlessness

  committed
  6f88032

  Copy full SHA for 6f88032

• TriggerableDagTest.java - port “codependant” tests

  eyelidlessness

  committed
  c6f5105

  Copy full SHA for c6f5105

• TriggerableDagTest.java - rest of cycles region, all concerned with repeats

  eyelidlessness

  committed
  3880f3c

  Copy full SHA for 3880f3c

• Generalization of custom assertions matching some static aspect of an object

  eyelidlessness

  committed
  d7ae12e

  Copy full SHA for d7ae12e

• Custom assertions: toBeRelevant, toBeNonRelevant

  eyelidlessness

  committed
  0b0d753

  Copy full SHA for 0b0d753

• TriggerableDagTest.java - port first relevant test…

  Show description for 02149b4
  eyelidlessness

  committed
  02149b4

  Copy full SHA for 02149b4

• TriggerableDagTest.java - port relevance exclusion test…

  Show description for 0f0570e
  eyelidlessness

  committed
  0f0570e

  Copy full SHA for 0f0570e

• TriggerableDagTest.java: port relevance tests with surprising assertions

  eyelidlessness

  committed
  99d6434

  Copy full SHA for 99d6434

• TriggerableDagTest.java - last test in relevance region

  Show description for 9baef38
  eyelidlessness

  committed
  9baef38

  Copy full SHA for 9baef38

• Add followup note on non-relevant node value assertions

  eyelidlessness

  committed
  ae5e693

  Copy full SHA for ae5e693

• Custom node state assertions for readonly…

  Show description for 006c3bf
  eyelidlessness

  committed
  006c3bf

  Copy full SHA for 006c3bf

• TriggerableDagTest.java - port first (only?) readonly test

  eyelidlessness

  committed
  cedfafa

  Copy full SHA for cedfafa

• TriggerableDagTest.java - port “Required and constraint” region

  eyelidlessness

  committed
  1a6f7df

  Copy full SHA for 1a6f7df

• TriggerableDagTest.java - move older ported repeat tests into describe group

  eyelidlessness

  committed
  38083b4

  Copy full SHA for 38083b4

• TriggerableDagTest.java - port first (well, next) repeat test

  Show description for b79ada6
  eyelidlessness

  committed
  b79ada6

  Copy full SHA for b79ada6

• TriggerableDagTest.java - port remainder of region “Adding or deleting repeats”

  eyelidlessness

  committed
  f9e74b2

  Copy full SHA for f9e74b2

• Regroup all tests from region “Adding or deleting repeats”

  eyelidlessness

  committed
  0eda13f

  Copy full SHA for 0eda13f

• TriggerableDagTest.java - several more repeat tests ported…

  Show description for 0db4191
  eyelidlessness

  committed
  0db4191

  Copy full SHA for 0db4191

• TriggerableDagTest.java - remainder of region: Deleting repeats

  eyelidlessness

  committed
  9905fc4

  Copy full SHA for 9905fc4

• TriggerableDagTest.java - region: Adding repeats

  eyelidlessness

  committed
  b3bbe71

  Copy full SHA for b3bbe71

• TriggerableDagTest.java - region: DAG limitations (cases that aren't correctly updated)

  eyelidlessness

  committed
  3300247

  Copy full SHA for 3300247

• Fix: mistaken placement of quote in ported JavaRosa form fixture DSL

  eyelidlessness

  committed
  82c5716

  Copy full SHA for 82c5716

• Port remainder of TriggerableDagTest.java(!)

  eyelidlessness

  committed
  21e296e

  Copy full SHA for 21e296e

• Port InstanceLoadEventsTest.java

  eyelidlessness

  committed
  16a6950

  Copy full SHA for 16a6950

• Port MultipleEventsTest.java

  eyelidlessness

  committed
  987ac3b

  Copy full SHA for 987ac3b

• Port OdkNewRepeatEventTest.java

  eyelidlessness

  committed
  fd7c7b7

  Copy full SHA for fd7c7b7

• RecordAudioActionTest.java - port second odk:recordaudio test

  Show description for c9b82f1
  eyelidlessness

  committed
  c9b82f1

  Copy full SHA for c9b82f1

• Port remainder of RecordAudioActionTest.java

  eyelidlessness

  committed
  80a23a8

  Copy full SHA for 80a23a8

• Port SetGeopointActionTest.java

  eyelidlessness

  committed
  54fd43b

  Copy full SHA for 54fd43b

• Port SetValueActionTest.java

  eyelidlessness

  committed
  c83a74c

  Copy full SHA for c83a74c

• Port ReadOnlyCalculateTest.java

  eyelidlessness

  committed
  7365f08

  Copy full SHA for 7365f08

• FormDefTest.java - port first two (constraint) tests

  eyelidlessness

  committed
  ae8b1fc

  Copy full SHA for ae8b1fc

• FormDefTest.java - port first repeat/relevant test

  Show description for edd39f7
  eyelidlessness

  committed
  edd39f7

  Copy full SHA for edd39f7

• FormDefTest.java - several more repeat/relevant tests

  Show description for 50425df
  eyelidlessness

  committed
  50425df

  Copy full SHA for 50425df

• FormDefTest.java - port last test from repeat/relevant region

  eyelidlessness

  committed
  f4e09d2

  Copy full SHA for f4e09d2

• FormDefTest.java - port first test of whether repeat instance can be created

  Show description for c7e1f8a
  eyelidlessness

  committed
  c7e1f8a

  Copy full SHA for c7e1f8a

• FormDefTest.java - port first test focused on interaction of repeat/output

  Show description for 4f1021e
  eyelidlessness

  committed
  4f1021e

  Copy full SHA for 4f1021e

• FormDefTest.java - port second test focused on interaction of repeat/output

  Show description for c64cd01
  eyelidlessness

  committed
  c64cd01

  Copy full SHA for c64cd01

• FormDefTest.java - port (as noop) last test: XPath function extensibility

  eyelidlessness

  committed
  6d07bdc

  Copy full SHA for 6d07bdc

• Add support for assymetric assertions where expected is primitive

  Show description for 4a4681a
  eyelidlessness

  committed
  4a4681a

  Copy full SHA for 4a4681a

• Introduce toStartWith custom answer assertion

  Show description for 27b41f7
  eyelidlessness

  committed
  27b41f7

  Copy full SHA for 27b41f7

• Port QuestionPreloaderTest.java

  eyelidlessness

  committed
  ebd5c9b

  Copy full SHA for ebd5c9b

• Port GeoAreaTest.java

  eyelidlessness

  committed
  297ec0f

  Copy full SHA for 297ec0f

• Port GeoDistanceTest.java

  eyelidlessness

  committed
  3a2d782

  Copy full SHA for 3a2d782

• Port (equivalent of) FormEntryModelTest.java

  Show description for d703546
  eyelidlessness

  committed
  d703546

  Copy full SHA for d703546

• Port FormEntryPromptTest.java

  Show description for e6351da
  eyelidlessness

  committed
  e6351da

  Copy full SHA for e6351da

• (Skipped) all entities tests

  Show description for 694b792
  eyelidlessness

  committed
  694b792

  Copy full SHA for 694b792

• Port MultiplePredicateTest.java

  eyelidlessness

  committed
  9576030

  Copy full SHA for 9576030

• Port XFormSerializingVisitorTest.java

  eyelidlessness

  committed
  29f0638

  Copy full SHA for 29f0638

• Port IndexedRepeatRelativeRefsTest.java

  eyelidlessness

  committed
  4e805ac

  Copy full SHA for 4e805ac

• Partially port/skip SameRefDifferentInstancesIssue449Test.java

  eyelidlessness

  committed
  4884140

  Copy full SHA for 4884140

• Port TriggersForRelativeRefsTest.java

  eyelidlessness

  committed
  203fa81

  Copy full SHA for 203fa81

• (Partially) port ChildVaccinationTest.java

  eyelidlessness

  committed
  e710211

  Copy full SHA for e710211

• Port WhoVATest.java smoketests

  eyelidlessness

  committed
  f0b383f

  Copy full SHA for f0b383f

• Formally skip FormEntryControllerTest.java with notes

  Show description for cba7a5c
  eyelidlessness

  committed
  cba7a5c

  Copy full SHA for cba7a5c

• Add suite for form-wide functionality, tests for form title

  Show description for 7fd26b7
  eyelidlessness

  committed
  7fd26b7

  Copy full SHA for 7fd26b7

• Port ExternalSecondaryInstanceParseTest.java

  Show description for 4f2dd82
  eyelidlessness

  committed
  4f2dd82

  Copy full SHA for 4f2dd82

• Minimal port of XFormParserTest.java

  Show description for 2cc1e46
  eyelidlessness

  committed
  2cc1e46

  Copy full SHA for 2cc1e46

• Port Base64DecodeTest.java

  eyelidlessness

  committed
  bdf7e65

  Copy full SHA for bdf7e65

• Port CurrentFieldRefTest.java

  eyelidlessness

  committed
  9de885c

  Copy full SHA for 9de885c

• Port CurrentGroupCountRefTest.java

  eyelidlessness

  committed
  fd1678c

  Copy full SHA for fd1678c

• Port CurrentTest.java

  eyelidlessness

  committed
  5100d0d

  Copy full SHA for 5100d0d

• Port DigestTest.java

  eyelidlessness

  committed
  d0aaa41

  Copy full SHA for d0aaa41

• Port ExtractSignedTest.java

  eyelidlessness

  committed
  9d23264

  Copy full SHA for 9d23264

• Remove now-unnecessary delay on Scenario.init

  eyelidlessness

  committed
  9ca6cd1

  Copy full SHA for 9ca6cd1

• Remove outdated mention of “memos below”.

  Show description for 39d3b26
  eyelidlessness

  committed
  39d3b26

  Copy full SHA for 39d3b26

• Update porting notes about all InconsistentChildrenStateError cases

  eyelidlessness

  committed
  7aea2c3

  Copy full SHA for 7aea2c3

• Remove unused fromReference parameter to getClosestRepeatRange

  eyelidlessness

  committed
  c85a897

  Copy full SHA for c85a897

• Address SelectNode.currentState.value[].label regression

  eyelidlessness

  committed
  0b88fb5

  Copy full SHA for 0b88fb5

• Fix: typo factionalDays -> fractionalDays

  eyelidlessness

  committed
  ac10658

  Copy full SHA for ac10658

• Fix: correct grammar in JSDoc

  eyelidlessness

  committed
  ddb9a5b

  Copy full SHA for ddb9a5b

• Eliminate redundant destructuring alias

  eyelidlessness

  committed
  62c104a

  Copy full SHA for 62c104a

• Update scenario package README status section

  eyelidlessness

  committed
  9ad7dc7

  Copy full SHA for 9ad7dc7

• Update JR comment copypasta in choice-name tests

  Show description for 67bfe9e
  eyelidlessness

  committed
  67bfe9e

  Copy full SHA for 67bfe9e

• Remove unused JR test function wrapper (relativeBodyRefTest)

  eyelidlessness

  committed
  4f86060

  Copy full SHA for 4f86060

• Update PORTING NOTES about XPathFuncExprRandomizeTest

  eyelidlessness

  committed
  b0e7317

  Copy full SHA for b0e7317

• Porting note about JavaRosa’s removeRepeat error message

  eyelidlessness

  committed
  f29f57e

  Copy full SHA for f29f57e

• Fix typo: fitler -> filter

  eyelidlessness

  committed
  2157c53

  Copy full SHA for 2157c53

• Copy notes about serializeAndDeserializeForm

  eyelidlessness

  committed
  554cf4c

  Copy full SHA for 554cf4c

• Rephrase first doNotGetConfused

  Show description for a105968
  eyelidlessness

  committed
  a105968

  Copy full SHA for a105968

• Update SelectChoice.getChild porting notes per PR comment

  eyelidlessness

  committed
  6c5176c

  Copy full SHA for 6c5176c

• Inline setup of SelectMultipleChoiceFilterTest.java tests

  eyelidlessness

  committed
  ae237aa

  Copy full SHA for ae237aa

• Rephrase removesIrrelevantAnswersAtAllLevels_withoutChangingOrder

  eyelidlessness

  committed
  3d3e6a2

  Copy full SHA for 3d3e6a2

• Inline setup in SelectOneChoiceFilterTest.java…

  Show description for b4d1cfd
  eyelidlessness

  committed
  b4d1cfd

  Copy full SHA for b4d1cfd

• Rephrase JR’s order_of_the_DAG_is_ensured

  eyelidlessness

  committed
  8bd2302

  Copy full SHA for 8bd2302

• Rephrase “read only” -> readonly

  eyelidlessness

  committed
  29762af

  Copy full SHA for 29762af

Commits on May 29, 2024

• Remove these comments

  eyelidlessness

  committed
  1594704

  Copy full SHA for 1594704

• Fix typo: “inf ields” -> "in fields”

  eyelidlessness

  committed
  ea4f509

  Copy full SHA for ea4f509

• Scenario.getAnswerNode -> getInstanceNode

  eyelidlessness

  committed
  f9bedd3

  Copy full SHA for f9bedd3

• Address relevant test which was intended to use a <repeat>

  eyelidlessness

  committed
  c997e85

  Copy full SHA for c997e85

• Update porting notes on contextualized count(abs path)…

  Show description for a3f4a91
  eyelidlessness

  committed
  a3f4a91

  Copy full SHA for a3f4a91

• Rephrase a few test descriptions (“repeat group”, “triggerables”)

  Show description for 73c1f14
  eyelidlessness

  committed
  73c1f14

  Copy full SHA for 73c1f14

• Update to range(1, …)

  eyelidlessness

  committed
  bf0cc74

  Copy full SHA for bf0cc74

• Confirmed intuition on this nullValue() check

  eyelidlessness

  committed
  5a23057

  Copy full SHA for 5a23057

• Update porting notes to reflect edits as a “second load” condition

  eyelidlessness

  committed
  e4ed69f

  Copy full SHA for e4ed69f

• Update porting notes about apparent intent of jr:count value casting

  eyelidlessness

  committed
  e1fb3fb

  Copy full SHA for e1fb3fb

• Rephrase repeatIsIrrelevant_whenRelevanceSetToFalse

  Show description for c62bb83
  eyelidlessness

  committed
  c62bb83

  Copy full SHA for c62bb83

• “I think usually these kinds of comments get a JR prefix. That'd be helpful.”

  eyelidlessness

  committed
  c723dbe

  Copy full SHA for c723dbe

• Add super helpful explanation of previously confusing error-on-read

  eyelidlessness

  committed
  a60e384

  Copy full SHA for a60e384

• Include answer to open questions about error on empty select

  eyelidlessness

  committed
  ca5afef

  Copy full SHA for ca5afef

Commits on May 30, 2024

• Rename Scenario .xhtml resource to .xml

  eyelidlessness

  committed
  16e4f56

  Copy full SHA for 16e4f56