Feature #710: View deleted Entities and restore Entities #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
force-pushed
the
features/710-delete-restore-entities
branch
from
747d373 to
4f18ade
Compare
|
Verify that duplicate UUID error is handled correctly in bulk Entities upload |
sadiqkhoja
force-pushed
the
features/710-delete-restore-entities
branch
from
4f18ade to
bbbcc71
Compare
sadiqkhoja
commented
Jan 6, 2025
| if (this.confirmDelete) { | ||
| this.uuidToDelete = entity.__id; | ||
| this.del.show({ label: entity.label }); | ||
| this.deleteModal.show({ entity }); |
There was a problem hiding this comment.
Passing whole entity object to make it consistent with restore and Submissions deleted/restore
sadiqkhoja
force-pushed
the
features/710-delete-restore-entities
branch
from
bbbcc71 to
2d3dd3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#710
What has been done to verify that this works as intended?
Added tests and verified manually.
Why is this the best possible solution? Were any other approaches considered?
Followed the existing code pattern.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Added in getodk/docs#1896
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes