Handle (ignore) observation epochs containing event flags #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Gerecke <[email protected]>
When parsing an epoch we want to ensure that we can at least read the date and time fields. This function will end up consuming non-epoch lines occasionally and we want to be sure that we bail early with an error rather than either barreling ahead and triggering an "invalid Gregorian date" panic or (even worse) assuming the bad parse is valid. Signed-off-by: Jason Gerecke <[email protected]>
Use the "format" function instead of the "format!" macro to verify that the module produces correctly-formatted epoch strings. Signed-off-by: Jason Gerecke <[email protected]>
Epoch flags are only used by observations, so it does not make sense to have their processing done within the epoch module. Moves processing and testing of the parsing and formatting of the flags over to the observation module. Signed-off-by: Jason Gerecke <[email protected]>
We don't yet actually *do* anything with events, but we can at least return an Error to prevent the rest of the system from trying to treat them as normal observations. Signed-off-by: Jason Gerecke <[email protected]>
Event flags 2 - 5 allow the epoch fields to be left blank if they are not "significant". Fixes: georust#219 Signed-off-by: Jason Gerecke <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
|
Thank you for your contributions! Planning: i'm working on positioning /performance upgrades in the rtk-0.5 branch, I will publish RINEX 0.16 once this one gets merged. If you're interested in an intermediate release, I can do that just let me know |
gwbres
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The epochs in an observation file contain flags that can have a value from 0 - 6. If the value is in the range 2 - 5 then it is an "event flag" that signals the following lines will contain type-specific data. Epochs with these particular flags are allowed to not have a date (if it is "not significant"), which would trip up our parsing of the file.
This patchset updates the parsing to better handle these situations. We don't yet do anything with these events, but not falling on our face is still an improvement :)
While we're at it, fix a bug in the meterological code that would trigger a test failure in the presence of some of the other patches in this set.
Fixes: #219