-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context improvements #209
Context improvements #209
Conversation
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Hello @lnicola I'm trying to improve the To give more context: With this PR i'm trying to fix that, mostly by introducing a lifetime to ======================= Well I found rapidly a solution to this, it turns out the inner type must be &mut Ref. |
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Sorry, I didn't have a chance to look at this yesterday, and now I'm pretty confused. Even when looking 91664b2 and only the |
But yeah, looking at that pattern, it might need a |
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Thank you once again for all your input, it turns out it is the "natural" conclusion I came with this morning, that I have injected with the latest commits. The conclusion is we have a solution to avoid this heavy memcopy, but it requires to slightly modify the way we operate/build/define the context at high level (in the applicatation itself) |
Signed-off-by: Guillaume W. Bres <[email protected]>
This PR improves and simplifies the
RnxContext
structure.It makes it more efficient to represent what is required in GNSS and RINEX post processing.
For example, it allows now to preprocess all types of products we support and generate new products.
It slightly reworks the way we operate the RnxContext structure and removes a big memcopy that was previously required in previous version, making the initial phase of the program more efficient.