Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci release #190

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Ci release #190

merged 3 commits into from
Dec 4, 2023

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Dec 1, 2023

No description provided.

Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres requested a review from lnicola December 1, 2023 19:20
Signed-off-by: Guillaume W. Bres <[email protected]>
@lnicola
Copy link
Member

lnicola commented Dec 2, 2023

I wonder if a single app-approach (rinex crx2rnx [stuff]) wouldn't be easier for the users.

If you need more inspiration for CI workflows, you can check out https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/release.yaml and https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/ci.yaml. They're not perfect, but maybe you see something interesting in there.

@gwbres
Copy link
Collaborator Author

gwbres commented Dec 3, 2023

I wonder if a single app-approach (rinex crx2rnx [stuff]) wouldn't be easier for the users.

If you need more inspiration for CI workflows, you can check out https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/release.yaml and https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/ci.yaml. They're not perfect, but maybe you see something interesting in there.

Thank you for pointing that out, I will take a look if we can grab a few things from there.

Regarding the app, honestly I don't know. It's only a matter of writing a different name in a workflow script.
Both approaches work, but either way it is important to maintain an access to dedicated functions like crx2rnx.
Because you can easily imagine some users might have their own processing programs but want to use our decompression program in their workflow

@gwbres
Copy link
Collaborator Author

gwbres commented Dec 4, 2023

If you need more inspiration for CI workflows, you can check out https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/release.yaml and https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/ci.yaml. They're not perfect, but maybe you see something interesting in there.

From what I can see we're not far from truth, they also use a very lengthy and tedious artifact upload then download then publish sucessive steps. Unfortunately the publish step is what it is, and the artifact download seems the only option to retrieve what you're interested in. I may try to use a strategy.matrix in the future, to reduce the length of the script.

I'll trigger this release to make sure the binaries name are correct.
Then we need one final PR for the artifacts actual publication

@gwbres gwbres merged commit b791eb0 into main Dec 4, 2023
4 checks passed
@gwbres gwbres deleted the ci-release branch December 4, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants