-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default config command #67
Open
hahmed
wants to merge
5
commits into
gel-rb:main
Choose a base branch
from
hahmed:add-default-config-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4a129e6
add default config comman
hahmed 91b9142
add test for config
hahmed 6edbbe0
use RACK_ENV
hahmed d7b4c73
cleanup config with a flat hash keeping it real simple
hahmed 855581f
cleanup code by moving env stuff into setup and teardown
hahmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# frozen_string_literal: true | ||
|
||
require "test_helper" | ||
|
||
class ConfigTest < Minitest::Test | ||
def setup | ||
@old_gel_config_env = ENV['GEL_CONFIG'] | ||
ENV['GEL_CONFIG'] = fixture_file('') | ||
end | ||
|
||
def teardown | ||
ENV['GEL_CONFIG'] = @old_gel_config_env | ||
end | ||
|
||
def test_reading_key_from_config_successully | ||
klass = Gel::Config.new | ||
assert_equal '316429e', klass['packages.example.io'] | ||
end | ||
|
||
def test_reading_group_key_from_config_successully | ||
klass = Gel::Config.new | ||
assert_equal '316429e', klass['packages', 'example.io'] | ||
end | ||
|
||
def test_reading_uppercase_key_from_config_successully | ||
klass = Gel::Config.new | ||
assert_equal 'true', klass['gem.MIT'] | ||
end | ||
|
||
def test_reading_all_from_config_successully | ||
settings = Gel::Config.new.all | ||
assert_equal '316429e', settings['packages.example.io'] | ||
assert_equal 'true', settings['gem.mit'] | ||
assert_equal '10', settings['timeout'] | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
packages.example.io: 316429e | ||
gem.mit: true | ||
timeout: 10 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewd I downcased to keep all settings consistent, also
strip
the value too. Without the null check&
some tests fail, I think it's because somewhere we are using the default -- bundler version for the config where we run all our tests, is that how it's supposed to work?