Print auto inertial values with gz sdf --print --expand-auto-inertials (backport #1422) #1526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #1348
Summary
The ability to automatically compute inertial values by setting the
//inertial/@auto
attribute to true is very convenient, but it is difficult to see what inertial values were computed. This adds a--expand-auto-inertials
argument togz sdf --print
to show the auto-computed inertial values in the printed output.To enable this behavior, a new enum value
SAVE_CALCULATION_IN_ELEMENT
is added toConfigureResolveAutoInertials
inParserConfig.hh
, and theLink
will store auto-computed inertial values directly in itssdf::Element
when this configuration is set.I am seeing a failing test on macOS locally but want to see if it is an issue on other platforms. EDIT: fixed in 2ffda3d.
Test it
INTEGRATION_link_dom
to verify the functionality of theLink
class withSAVE_CALCULATION_IN_ELEMENT
UNIT_gz_TEST
to verify the--expand-auto-inertials
parameter togz sdf --print
colcon
workspace withgz-tools2
, thengz sdf --print test/sdf/inertial_stats_auto.sdf
with and without--expand-auto-inertials
should demonstrate the feature.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.This is an automatic backport of pull request #1422 done by [Mergify](https://mergify.com).