Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse kinematic property in link #1390

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Parse kinematic property in link #1390

merged 2 commits into from
Apr 4, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 2, 2024

🎉 New feature

Summary

Parses <kinematic> SDF element in <link> and stores the bool value in Link DOM.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested review from azeey and scpeters as code owners April 2, 2024 02:08
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (67ead53) to head (c086ff1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1390   +/-   ##
=======================================
  Coverage   92.44%   92.45%           
=======================================
  Files         134      134           
  Lines       17812    17820    +8     
=======================================
+ Hits        16467    16475    +8     
  Misses       1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/sdf/Link.hh Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from ahcorde April 4, 2024 17:37
@iche033 iche033 merged commit c8e9891 into main Apr 4, 2024
9 of 10 checks passed
@iche033 iche033 deleted the kinematic branch April 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants