[Protocol] Make gamespy1 parsing less likely to fail #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields seem to be missing from bf1942 queries so make them optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "playername" field being filtered out, which would cause parsing to fail for some
bf1942servers which use that field instead of "player".It also makes more fields on the Gamespy1 Player type optional, this is because in my testing I saw some servers (
bf1942) not providing them so as a result the parse would fail if these were not optional.This is taken from #92 but is just partial work on #88, it might not solve all issues, but they are the obvious fixes that should help us in narrowing down the other ones.