-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron and Dependencies update #801
Conversation
Seems like it's not finding pre-built binaries for ( |
Updated the nodejs version from 16 to 18 in the workflow files and that seemed to fix it. |
Checked it locally (ARM macOS 13.5) nothing overtly broken, looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why package-lock.json was never committed
Else, LGTM
No, looks like it was removed from the master branch since 2018), but did add in |
I was thinking there might be a legitimate reason why yarn.lock was not included |
Since Yarn was implemented as the tool of choice by using the @18alantom Is/Was there issues previously with having the yarn.lock file present in the repo and/or should there be a package-lock.json as well? |
This is a supplemental PR (meant to be an update and replacement for PR#751).
Updates
electron
-> 18.3.7 -> 22.3.27electron-builder
24.4.0 -> 24.9.1electron-updater
5.2.1 -> 6.1.7better-sqlite3
7.5.3 -> 9.2.2electron-rebuild
-> updated to@electron/rebuild
w/version 3.4.1Currently, with updated electron versions, there is an issue where the
node-abi
version can't be automatically detected w/electron-builder
. To get around this issue, thenode-abi
version was added in the "resolutions" portion of the package.json