Merge pull request #821 from frappe/fix_ytd_chart_issues_divide_by_0

Fix ytd chart issues divide by 0
frappe · Jan 25, 2024 · 9c92a4f · 9c92a4f
2 parents 7e1de76 + 808116d
commit 9c92a4f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/Charts/BarChart.vue b/src/components/Charts/BarChart.vue
@@ -196,7 +196,7 @@ export default {
             this.padding +
             this.left +
             (i * (this.viewBoxWidth - this.left - 2 * this.padding)) /
-              (this.count - 1)
+              (this.count - 1 || 1) // The "or" one (1) prevents accidentally dividing by 0
         );
     },
     z() {

diff --git a/src/components/Charts/LineChart.vue b/src/components/Charts/LineChart.vue
@@ -193,7 +193,7 @@ export default {
             this.padding +
             this.left +
             (i * (this.viewBoxWidth - this.left - 2 * this.padding)) /
-              (this.count - 1)
+              (this.count - 1 || 1) // The "or" one (1) prevents accidentally dividing by 0
         );
     },
     ys() {