Print max fee conversion info when using v3 txs #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
requested review from
cptartur,
ddoktorski and
kkawula
as code owners
ksew1
reviewed
Dec 18, 2024
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2706-validate-fee-args-greater-than-zero
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
ksew1
reviewed
Dec 19, 2024
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… into franciszekjob/2706-validate-fee-args-greater-than-zero
Draggu
reviewed
Jan 7, 2025
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
Co-authored-by: Piotr Figiela <[email protected]>
…th-v3-txs' of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
… into franciszekjob/2706-validate-fee-args-greater-than-zero
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2706-validate-fee-args-greater-than-zero
… of https://github.com/foundry-rs/starknet-foundry into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
Base automatically changed from
franciszekjob/2706-validate-fee-args-greater-than-zero
to
master
January 14, 2025 13:58
… into franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
franciszekjob
deleted the
franciszekjob/2707-show-info-about-converted-max-fee-with-v3-txs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2707
Introduced changes
Display info about about conversion when using
--max-feeflag with v3 transactionsChecklist
CHANGELOG.md