Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow progress notification without real lsp #683

Closed
wants to merge 1 commit into from

Conversation

rtgiskard
Copy link

@rtgiskard rtgiskard commented Dec 30, 2023

This is a try to support #682

example:

local noice_progress = require('noice.lsp.progress')

--  provide a fake lsp client name
local client_name = 'stylua'

-- begin the progress notification with no percentage
local msg_id = noice_progress.progress_msg(client_name, {title = 'check ..'})

-- update the progress message
noice_progress.progress_msg(client_name, {title = 'format ..', percentage = 40, id = msg_id})

-- once operation is done, use the `msg_id` to finish the progress
noice_progress.progress_msg_end(msg_id)

@rtgiskard rtgiskard force-pushed the main branch 3 times, most recently from 2d7be00 to 78b2faa Compare December 31, 2023 10:21
rtgiskard added a commit to rtgiskard/lazyNvim that referenced this pull request Jan 2, 2024
rtgiskard added a commit to rtgiskard/lazyNvim that referenced this pull request Jan 2, 2024
@rtgiskard
Copy link
Author

rtgiskard commented Apr 2, 2024

@folke Hello, This PR has been there for quite some time, just wanted to kindly remind you of its existence.

This is an effort to implement the feature in #682, which allow progress message for external tools without a lsp server. As I think this could be helpful, would you like to spare some time to have a review, I would really appreciate any feedback you might have.

Copy link

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@rtgiskard
Copy link
Author

A polite ping, just rebased, the code should be fine with no obscure logic. If there are any concerns, please tell, and I'll check whether there be any things I can do

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 25, 2024
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 25, 2024
@folke
Copy link
Owner

folke commented Nov 8, 2024

Thank you for your PR, but I'm not interested in adding this.

@folke folke closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants