-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC-0008] Custom Event Metadata from Annotations #4809
[RFC-0008] Custom Event Metadata from Annotations #4809
Conversation
This is great! Thanks again for picking this up, @matheuscscp 🎉 ! I have nothing to add. It explains the use case very well. Regarding the API group, I don't know enough about the benefits of implementing the |
6d5ee27
to
14079bc
Compare
a2c7092
to
f9571f8
Compare
7b62750
to
0928016
Compare
51936fa
to
ad059ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
ad059ae
to
e338913
Compare
I would love to see this RFC merged. Is there anything I can do ? Also for the implementation. Who's gonna make it ? I am interested to help with my low-level Go skills. :) Thanks |
Hi @benoittgt! Thanks for reaching out! I'm working on this RFC. I'm on vacations this week, but I will pick up the pace next week :) Stay tuned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this improvement!
052da50
to
1768ecf
Compare
4763c5b
to
a71d0b7
Compare
c546fa7
to
73d23f1
Compare
73d23f1
to
b81f480
Compare
cd45381
to
820476b
Compare
684d677
to
8492711
Compare
Signed-off-by: Matheus Pimenta <[email protected]>
8492711
to
83c16f9
Compare
This RFC comes as a response to the need for adding custom metadata to events about Flux objects
sent to notification providers.
When a Flux controller sends events about Flux objects, we propose sending annotation keys prefixed with the well-defined API Group
event.toolkit.fluxcd.io
followed by a slash, i.e. prefixed withevent.toolkit.fluxcd.io/
, in addition to all the metadata that is already sent by the controller.