Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @matheuscscp to core maintainers #421

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Dec 3, 2024

In my new position I can dedicate a lot of time to Flux development and my personal goal is to make the question "what GitOps tool should I choose for my Kubernetes cluster?" as trivial as it for me to everybody else in the world :)

Signed-off-by: Matheus Pimenta <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks @matheuscscp for all the hard work so far 🥇

@makkes
Copy link
Member

makkes commented Dec 5, 2024

I just went through our process doc on this and there's a couple of things to take into account:

@makkes
Copy link
Member

makkes commented Dec 5, 2024

+1

@stefanprodan
Copy link
Member

stefanprodan commented Dec 5, 2024

I think approving the PR is the same as commenting with +1. But yes we need two more!

Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@souleb
Copy link
Member

souleb commented Dec 5, 2024

+1

@aryan9600
Copy link
Member

+1 from me!

@stefanprodan
Copy link
Member

We have unanimity, thanks everyone and a big welcome to Matheus 🎉

@stefanprodan stefanprodan merged commit 665b9bc into fluxcd:main Dec 5, 2024
2 checks passed
@matheuscscp
Copy link
Member Author

🙏 🙌 😭 🚀

@matheuscscp matheuscscp deleted the matheuscscp-coremaintainer branch December 5, 2024 12:12
@makkes
Copy link
Member

makkes commented Dec 5, 2024

I think approving the PR is the same as commenting with +1. But yes we need two more!

The docs say we must comment with +1. 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants