[video_player] Activate leak testing #8379
Open
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I modified only the tests, I think this PR is eligible for the tags |
|
cc @polina-c |
ValentinVignal
commented
Jan 7, 2025
| @@ -698,6 +723,7 @@ void main() { | |||
| expect(controller.value.isPlaying, isTrue); | |||
|
|
|||
| await controller.pause(); | |||
| await tester.runAsync(controller.dispose); | |||
There was a problem hiding this comment.
For those ones, I didn't manage to make the test pass without using runAsync.
If I use
addTearDown(() {
controller.dispose();
});or
// end of test
unawaited(controller.dispose());
// a lot of
tester.pump();
tester.pump();it doesn't fix the memory leak.
If I use
addTearDown(controller.dispose());or
// end of test
await controller.dispose();the test hangs and times out.
Do you have an idea on how to do it better?
There was a problem hiding this comment.
It looks smelly for me that dispose is async. But, it is test only class, so it is ok.
And thus runAsync makes perfect sense.
polina-c
added
the
a: leak tracking
ValentinVignal
force-pushed
the
video-player/activate-leak-testing
branch
from
b1e7de6 to
19261d2
Compare
|
Any thoughts on this PR @tarrinneal ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package manipulates disposable objects. This PR activates leak testing to make sure disposable objects are correctly disposed.
It also fixes the memory leak warnings from the tests
See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.