Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong virtual import content #99

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

florian-lefebvre
Copy link
Owner

If you have a look at the playground diff, before this PR whatever-b would also return whatever-a's content

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for astro-integration-kit ready!

Name Link
🔨 Latest commit e99550d
🔍 Latest deploy log https://app.netlify.com/sites/astro-integration-kit/deploys/662a2500a6e3b600083a0095
😎 Deploy Preview https://deploy-preview-99--astro-integration-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florian-lefebvre florian-lefebvre merged commit cc1e92b into main Apr 25, 2024
7 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/virtual-imports-wrong-content branch April 25, 2024 09:48
Comment on lines +84 to +87
_import.id === resolution &&
(_import.context === undefined
? true
: _import.context === context),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be the same as this:

Suggested change
_import.id === resolution &&
(_import.context === undefined
? true
: _import.context === context),
_import.id === resolution &&
(_import.context === undefined || _import.context === context),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants