Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for subtyping and extra integration fields #98

Merged
merged 12 commits into from
Apr 13, 2024

Conversation

Fryuni
Copy link
Collaborator

@Fryuni Fryuni commented Apr 10, 2024

No description provided.

@Fryuni Fryuni requested a review from florian-lefebvre April 10, 2024 19:09
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for astro-integration-kit ready!

Name Link
🔨 Latest commit f1ab646
🔍 Latest deploy log https://app.netlify.com/sites/astro-integration-kit/deploys/6619758610103c00083f0604
😎 Deploy Preview https://deploy-preview-98--astro-integration-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the changeset and update the upgrade guide? Other than that, LGTM!

@Fryuni
Copy link
Collaborator Author

Fryuni commented Apr 10, 2024

🎉 Great, will do so

@BryceRussell
Copy link
Collaborator

BryceRussell commented Apr 10, 2024

The highlighting on all the code blocks needs to be updated as well

@Fryuni Fryuni requested a review from florian-lefebvre April 12, 2024 04:28
Fryuni and others added 2 commits April 12, 2024 08:03
Copy link
Collaborator

@BryceRussell BryceRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I squeezed in two small fixes I found in docs, I hope that is ok)

@florian-lefebvre florian-lefebvre changed the title feat!: Add support for subtyping and extra integration fields feat!: add support for subtyping and extra integration fields Apr 13, 2024
@florian-lefebvre florian-lefebvre merged commit 29d6305 into main Apr 13, 2024
7 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/defineIntegration-subtyping branch April 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants