Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds an explanation page #41

Merged
merged 9 commits into from
Feb 2, 2024

Conversation

jdtjenkins
Copy link
Collaborator

Closes #39

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for astro-integration-kit ready!

Name Link
🔨 Latest commit 2aa494c
🔍 Latest deploy log https://app.netlify.com/sites/astro-integration-kit/deploys/65bcca3caa5e06000872be42
😎 Deploy Preview https://deploy-preview-41--astro-integration-kit.netlify.app/getting-started/why
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. I sent the text suggested by Grammarly Pro using:

  • Domain: General
  • Intent: Tell a Story
  • Audience: General
  • Formality: Neutral

docs/src/content/docs/getting-started/why.mdx Outdated Show resolved Hide resolved
Copy link
Owner

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, thank you! It would be great to have a CTA (likely a :::note) at the bottom that:

  • incites people to contribute and give feedback
  • links to the github repo + the discord channel

Also, I feel like having this as the 1st element of the sidebar is a bit much. Even in astro docs it stands in a different section. I think 3rd would be ideal

docs/src/content/docs/getting-started/why.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/getting-started/why.mdx Outdated Show resolved Hide resolved
@florian-lefebvre florian-lefebvre changed the title Adds a "why aik" page docs: adds an explanation page Feb 2, 2024
@florian-lefebvre florian-lefebvre merged commit 54d129f into florian-lefebvre:main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Why AIK" section
3 participants