Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github actions workflow added for linting #122

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ITZSHOAIB
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for astro-integration-kit ready!

Name Link
🔨 Latest commit 5ca9ca6
🔍 Latest deploy log https://app.netlify.com/sites/astro-integration-kit/deploys/673f3ed20c64ad0008d0aa22
😎 Deploy Preview https://deploy-preview-122--astro-integration-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,25 @@
name: Lint

on: [pull_request]
Copy link
Collaborator

@Fryuni Fryuni Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the appropriate config. The pull_request trigger will run for unrelated changes. Changing labels, titles and descriptions should not re-run a linter

This should either be on push or have the config for opened and synchronize for the pull_request trigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in the latest commit.

Copy link
Collaborator

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@florian-lefebvre florian-lefebvre merged commit 5fe7751 into florian-lefebvre:main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants