-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: github actions workflow added for linting #122
feat: github actions workflow added for linting #122
Conversation
✅ Deploy Preview for astro-integration-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.github/workflows/lint.yml
Outdated
@@ -0,0 +1,25 @@ | |||
name: Lint | |||
|
|||
on: [pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the appropriate config. The pull_request
trigger will run for unrelated changes. Changing labels, titles and descriptions should not re-run a linter
This should either be on push or have the config for opened
and synchronize
for the pull_request
trigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
No description provided.