Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options to manage subscriptions #67

Open
wants to merge 2 commits into
base: 2.6
Choose a base branch
from

Conversation

ElsaWeb
Copy link

@ElsaWeb ElsaWeb commented Jul 26, 2021

Hello,

I have continued to work on Cachet during the past few weeks and you may be interested on these features.

This PR gives a finer grained control to subscribers to manage their subscriptions.

  • Additionally to the component lists, a subscriber can choose to be notified to component updates (vs only incidents affecting the components).
  • They can also choose to receive notifications about maintenances, whereas they would previously only receive them when being subscribed to all components (what was called 'globally').
  • Finally, a subscriber can choose to be subscribed globally, i.e. receive notifications about incidents that are not affecting any components.

This follows #62 who should probably merged first, but if needed I may split them.

Thanks,

ElsaWeb added 2 commits June 17, 2021 11:27
* Fix a translation path.
* Make component updates from incident trigger the normal event for component updates
* Remove the `ShouldQueue` of `NewScheduleNotifications` to make it consistent with the others
* Add a name to subscribers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant