Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player: show warning when user removes the current song in some cases #897

Merged
merged 2 commits into from
Jan 16, 2025
Merged

player: show warning when user removes the current song in some cases #897

merged 2 commits into from
Jan 16, 2025

Conversation

cosven
Copy link
Member

@cosven cosven commented Jan 15, 2025 •
edited
Loading

  1. It can't be removed when the current song is the last in FM mode.
  2. pytest: less warnings

@coveralls
Copy link

coveralls commented Jan 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12792330597

Details

  • 5 of 10 (50.0%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 56.705%
Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/components/player_playlist.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
feeluown/player/delegate.py 2 82.76%
feeluown/library/library.py 5 67.16%
Totals Coverage Status
Change from base Build 12689955714: -0.07%
Covered Lines: 9984
Relevant Lines: 17607
💛 - Coveralls

@cosven cosven merged commit d9f39dc into feeluown:master Jan 16, 2025
7 of 9 checks passed
@cosven cosven deleted the fix-fm-last-song branch January 16, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosven @coveralls