Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: link Using Copr CLI - Custom build method video #3198

Merged
merged 1 commit into from
Apr 2, 2024
Merged

doc: link Using Copr CLI - Custom build method video #3198

merged 1 commit into from
Apr 2, 2024

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Mar 28, 2024

nikromen
nikromen approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@nikromen nikromen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@praiskup
Copy link
Member

praiskup commented Apr 2, 2024

Very nice, I'd just suggest double-quoting all the shell variables (always, except for assignments); it just irritates my OCD.

@praiskup praiskup merged commit 15fd1b5 into fedora-copr:main Apr 2, 2024
6 checks passed
@FrostyX
Copy link
Member Author

FrostyX commented Apr 2, 2024

I'd just suggest double-quoting all the shell variables (always, except for assignments); it just irritates my OCD.

You are right, thank you. I always forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikromen nikromen nikromen approved these changes

@praiskup praiskup praiskup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrostyX @praiskup @nikromen