Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: migrate monitor, modules, mock_chroots, webhooks enpoints to restx #3133

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

nikromen
Copy link
Member

@nikromen nikromen commented Feb 6, 2024

Fixes: #2998

@nikromen nikromen marked this pull request as draft February 6, 2024 17:13
@nikromen nikromen marked this pull request as ready for review February 11, 2024 14:40
@nikromen nikromen force-pushed the tiny-endpoints branch 2 times, most recently from 7581e7a to 53907e4 Compare February 11, 2024 14:53
@nikromen nikromen requested a review from FrostyX February 11, 2024 14:55
Copy link
Member

@FrostyX FrostyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed it through and it looks good to me.
Same rewrite as previous namespaces, no new hacks

There are some namespaces still remaining, I'd go with the easiest first and leaving the builds, which are IMHO the hardest as the last (so we can potentially drop some compatibility hacks there), and in its own PR.

@FrostyX FrostyX merged commit 9fcb724 into fedora-copr:main Feb 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert tiny endpoints to flask-restx
2 participants