Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instance types #5

Merged
merged 1 commit into from
Jan 10, 2024
Merged

update instance types #5

merged 1 commit into from
Jan 10, 2024

Conversation

xsuchy
Copy link
Member

@xsuchy xsuchy commented Jan 4, 2024

both has been recently upgrade to meet the demand

@@ -85,7 +85,7 @@ keygen:
image: f39
old_instance_id: i-0efff0067789ed7a9
new_instance_id: i-01b4f20bd9fb1bea6
instance_type: t3a.xlarge
instance_type: c7a.4xlarge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't supposed to stay, I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know. :) But it is a reality now. We can change it later when we change it back in AWS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move to c7a indeed, though not 4xlarge, that's just too big ... namely after releasing
fedora-copr/copr#3052

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change it later when we change it back in AWS.

There's high chance we will forget about it :-) and we will start too-expensive instance once migrating to F41. I'd prefer either fixing this directly to c7a.xlarge, or wait with this PR till we have fedora-copr/copr#3052 deployed in prod.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will not forget.

But if you insist I will either remove or change it to xlarge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please specify there the expected value. I think it should be c7a.xlarge.

both has been recently upgrade to meet the demand

Note that keygen is currently c7a.4xlarge but after deploying
fedora-copr/copr#3052 it should return back to xlarge, but rather c7a
than t3a.
@xsuchy
Copy link
Member Author

xsuchy commented Jan 5, 2024

Updated.

@praiskup praiskup merged commit b87a952 into main Jan 10, 2024
@praiskup
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants